Build for WIN32 with MSVC 2008 #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To compile for Visual C / WIN32 the following changes were required: (multiple files) + inline was defined as __inline + variable declarations were moved to the beginning of scope blocks. + partially expanded GSK_LIST_* macros. (macros are expanded differently under Visual C than they are udner gcc). + Removed support for PROTOBUF_C_RPC_ADDRESS_LOCAL; it depends on AF_UNIX. + Removed support for protobuf_c_rpc_server_configure_threading; it depends on pipe(). Windows has pipe support (using CreatePipe) but has different semantics. protobuf-c-rpc-dispatch.c + Replaced FDMap sparsed array with sorted array of FDMap. + Replaced timer tree with a sorted linked list. Neither of these changes are quite as efficient as how the code was previously; however the number of FDs or timers would have to be very large to see a performance impact. Because macro expansion works differently in VC than gcc, the red-black tree code is impossible to compile, even attempting to partially expand the initial macros. To compile for Windows CE: + errno defined to WSAGetLastError() + strerror implemented using FormatMessage. + non-polling (select) based dispatch model implemented. Signed-off-by: Mark Salisbury <[email protected]>
Member
|
Hi Mark,
Looking at changes in smaller batches would help identify potential problems. Would you be able to separate the changes? |
Author
|
Thanks Ilya. I'll need to figure out how to run the tests locally... Looking at the log, it says: "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself." After the "verify client cannot connect" test begins. The changes can't be really broken down much since the point of the changes is to compile with VS 2008 for Windows platforms. It may be possible to reduce the turmoil to some degree by not including changes for running on Windows CE. |
|
It seems like some of these could come in separate from the Win32 and WinCE changes. Maybe these ones:
protobuf-c-rpc-dispatch.c
I think it can be broken apart, not fun but do-able. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To compile for Visual C / WIN32 the following changes were required:
(multiple files)
under Visual C than they are udner gcc).
it depends on pipe(). Windows has pipe support (using CreatePipe) but
has different semantics.
protobuf-c-rpc-dispatch.c
Neither of these changes are quite as efficient as how the code was
previously; however the number of FDs or timers would have to be very
large to see a performance impact.
Because macro expansion works differently in VC than gcc, the red-black
tree code is impossible to compile, even attempting to partially
expand the initial macros.
To compile for Windows CE:
Signed-off-by: Mark Salisbury [email protected]